wgpu-hal: Expose vulkan::PhysicalDeviceFeatures #7682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah clippy complains because the documentation links to private items now, not sure what to do about this since the function it links to does indeed seem pretty internal. |
cwfitzgerald
requested changes
May 29, 2025
wgpu-hal/src/vulkan/mod.rs
Outdated
| downlevel_flags: wgt::DownlevelFlags, | ||
| private_caps: PrivateCapabilities, | ||
| workarounds: Workarounds, | ||
| } | ||
|
|
||
| pub use adapter::PhysicalDeviceFeatures; |
There was a problem hiding this comment.
Definitely shouldn't put the use here - if anything it should be re-exported at the top of the file, near any other re-exports.
There was a problem hiding this comment.
Moved it to be in-line with what the order in wgpu-hal/src/dynamic/mod.rs is (this file didn't have any other re-exports).
afishhh
force-pushed
the
public_physical_device_features
branch
from
9092660 to
bef8699
Compare
afishhh
force-pushed
the
public_physical_device_features
branch
from
bef8699 to
754bb81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7681
Description
PhysicalDeviceFeaturesis currently accessible throughvulkan::Adapter::physical_device_featureswhich is a public function. This structure seems required to be able to tell what Vulkan device features wgpu needs so it would be nice if it was accessible externally as otherwise it's impossible to create a wgpuDevicefrom Vulkan objects safely.Re-exporting the type is the workaround I used just to get what I was doing to succeed, alternatively the whole
adaptermodule could be made public or glob re-exported, this would also exposePhysicalDevicePropertieswhich appears to have the same issue.Testing
Call
Adapter::physical_device_features, notice that you can't name this type due to it being private.Squash or Rebase?
Any
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.